chore: local -> external builder mapping#47
Merged
avalonche merged 5 commits intoflashbots:mainfrom Jan 31, 2025
Merged
Conversation
Contributor
Author
|
@avalonche can you pls check if the logic makes sense? |
Member
|
thanks for the PR! will review soon! |
avalonche
reviewed
Jan 21, 2025
avalonche
reviewed
Jan 21, 2025
avalonche
approved these changes
Jan 21, 2025
Collaborator
avalonche
left a comment
There was a problem hiding this comment.
LGTM, it'll be great if you can add some tests asserting when
- payload ids are the same
- payload ids are different
and check that the correct payload id is used.
Also there seems to be lint issues
Contributor
Author
|
Thanks for the review @avalonche . Addressed it! |
Collaborator
|
I've fixed some failing tests here |
Contributor
Author
|
Thanks! I see it was about running the tests sequentially. Personally not a fan of having all of them under |
theochap
pushed a commit
to ethereum-optimism/optimism
that referenced
this pull request
Feb 13, 2026
…ing-builder chore: local -> external builder mapping
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Overview
This PR adds payload ID mapping functionality to track and map between local and external payload IDs when interacting with the builder node. This ensures proper correlation between payloads across different nodes.
Key changes:
local_to_external_payload_idscache toPayloadTraceContextto store mappingsget_payload_v3to use external payload ID when requesting from builderfork_choice_updated_v3response handlingThe changes help maintain proper tracing and correlation between local execution engine payloads and external builder payloads, improving debuggability and reliability of the system.
fixes #46