fix(disk): ignore_mount_points not work for device_error=1#1449
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a disk input bug where ignore_mount_points was not applied to mount points reported with device_error=1, by moving the ignore check to the beginning of the per-mount loop so ignored paths are skipped before any reporting.
Changes:
- Move
ignore_mount_pointsfiltering to the top of the disk iteration loop to ensure it applies even whendevice_error=1. - Adjust the disk collection loop structure accordingly (with additional inline comments).
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Collaborator
|
Thank you @wujian3691 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixed the bug that the
ignore_mount_pointsconfiguration does not take effect for disk mount points withdevice_error=1.Root cause: The ignore logic was executed after the device error judgment, causing error mount points to be directly reported without being ignored.
Fix: Move the
ignore_mount_pointscheck to the first line of the for loop.