Skip to content

fix(disk): ignore_mount_points not work for device_error=1#1449

Merged
kongfei605 merged 2 commits into
flashcatcloud:mainfrom
wujian3691:main
Jun 4, 2026
Merged

fix(disk): ignore_mount_points not work for device_error=1#1449
kongfei605 merged 2 commits into
flashcatcloud:mainfrom
wujian3691:main

Conversation

@wujian3691
Copy link
Copy Markdown
Contributor

Fixed the bug that the ignore_mount_points configuration does not take effect for disk mount points with device_error=1.

Root cause: The ignore logic was executed after the device error judgment, causing error mount points to be directly reported without being ignored.
Fix: Move the ignore_mount_points check to the first line of the for loop.

Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

Fixes a disk input bug where ignore_mount_points was not applied to mount points reported with device_error=1, by moving the ignore check to the beginning of the per-mount loop so ignored paths are skipped before any reporting.

Changes:

  • Move ignore_mount_points filtering to the top of the disk iteration loop to ensure it applies even when device_error=1.
  • Adjust the disk collection loop structure accordingly (with additional inline comments).

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread inputs/disk/disk.go
Comment thread inputs/disk/disk.go Outdated
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
@kongfei605
Copy link
Copy Markdown
Collaborator

Thank you @wujian3691

@kongfei605 kongfei605 merged commit 35b7307 into flashcatcloud:main Jun 4, 2026
1 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants