chore: bump go-flashduty — drop notify-rule commands + omitempty responses#29
Merged
Merged
Conversation
…onses Bumps go-flashduty to main (b12fb6a): #6 omitempty request/response split + #7 sync that drops the stale /channel/notify/rule/* endpoints. Regenerated via cligen: 254→248 commands; the 6 ChannelNotifyRule commands drop from zz_generated_channels.go (their SDK methods no longer exist — they 404'd anyway). The omitempty split flows through the SDK dependency at runtime (response false/0/[]/{} now survive --json/--toon); no CLI codegen delta from it. build/vet/test green. No release.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Bumps
go-flashdutyto main (b12fb6a): #6 omitempty request/response split + #7 spec sync dropping the stale/channel/notify/rule/*endpoints.cligen regen: 254→248 commands; the 6
ChannelNotifyRulecommands drop fromzz_generated_channels.go(their SDK methods no longer exist — they 404'd anyway). The omitempty split flows through the SDK dependency at runtime; no CLI codegen delta from it.Live-verified (rebuilt binary vs api-dev):
fduty channel --helpno longer listsnotify-rule-*(escalate/inhibit/silence/unsubscribe rules — which have real backend handlers — remain).fduty incident list --jsonnow renders 21 zero/false/empty fields per row (e.g.ack_time=0,closer_id=0,description="") that omitempty previously swallowed.build/vet/test green. No release.