feat: adopt typed timestamps from flashduty-sdk (RFC3339 output)#60
Merged
Conversation
Bump flashduty-sdk to the Timestamp/TimestampMilli release. mcp marshals SDK results straight through MarshalResult -> sdk.Marshal, so tool output now renders RFC3339 (JSON and TOON) with no source change. Add a regression test pinning that behavior.
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Bump
flashduty-sdkto theTimestamp/TimestampMillirelease. The MCP server marshals SDK results straight throughMarshalResult→sdk.Marshal, so tool output now renders RFC3339 (JSON and TOON) with zero source changes — the new types carry their ownMarshalJSON/String().Depends on flashduty-sdk PR #20 (
flashcatcloud/flashduty-sdk#20). go.mod pins the SDK at the PR branch commit via pseudo-version; will re-pin to the tagged/merged SHA once #20 lands.Changes
go.mod/go.sum— SDK dependency bump.pkg/flashduty/marshal_time_test.go(new) — regression test pinning RFC3339 rendering through both JSON and TOON output paths.Verification
go build ./... && go vet ./... && go test -race ./...— all greengofmt -lon changed files — cleangolangci-lint run ./...(v2.11.4) — 0 issuesNote (out of scope)
Same pre-existing stale
golangci-lintMakefile pin as the CLI repo; CI is unaffected. Left untouched to keep this PR scoped.