chore: turn flashduty-sdk into a polished open-source project#14
Merged
Conversation
Add the standard open-source kit modeled on flashduty-mcp-server: - LICENSE (MIT) — fixes the previously dead README link - Community-health docs: CONTRIBUTING, CODE_OF_CONDUCT (Contributor Covenant by-reference), SECURITY, SUPPORT - .github metadata: CODEOWNERS, dependabot (gomod + actions), PR template, bug/feature issue templates - CI workflows: go.yml (test -race + build, 3 OSes), lint.yml (golangci-lint v2.11), code-scanning.yml (CodeQL) - .golangci.yml matching the sibling repo's lint standard - README badges + Contributing/Development/License sections, plus a Chinese README_zh.md Also fix the six lint findings so CI ships green: drop a dead nil-guard and unused param in monitors.go, remove the unused parseCommaSeparatedInts helper, convert an if/else-if channel check to a tagged switch, and ignore writer return values in test HTTP stubs.
|
You are seeing this message because GitHub Code Scanning has recently been set up for this repository, or this pull request contains the workflow file for the Code Scanning tool. What Enabling Code Scanning Means:
For more information about GitHub Code Scanning, check out the documentation. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Brings
flashduty-sdkup to the same open-source standard asflashduty-mcp-server, so it can stand on its own as a public Go library.LICENSEbut the file was missing; this fixes the dead link.CONTRIBUTING.md,CODE_OF_CONDUCT.md(Contributor Covenant 2.1, adopted by reference),SECURITY.md,SUPPORT.md..githubmetadata —CODEOWNERS,dependabot.yml(gomod + github-actions, weekly), PR template, bug/feature issue templates.go.yml(go test -race+ build across Linux/Windows/macOS),lint.yml(golangci-lint v2.11),code-scanning.yml(CodeQL)..golangci.yml— matches the sibling repo's lint standard (with a test-file exclusion for the expected gosec false positives).README_zh.md.To keep lint CI green, six existing findings are fixed (all behavior-preserving):
monitors.go— dropped a dead nil-guard and blanked an unused parameter.helpers.go— removed the unusedparseCommaSeparatedIntshelper (and its now-unusedstrconvimport).templates.go— converted anif/else ifchannel check into a taggedswitch.logger_test.go,templates_test.go— ignore writer return values in test HTTP stubs.Test plan
go build ./...go vet ./...go test -race ./...golangci-lint run ./...— 0 issues@flashcatcloud/flashduty-sdkteam so CODEOWNERS resolves