-
Notifications
You must be signed in to change notification settings - Fork 4
Update flashinfer-bench doc link #6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters (2)
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including You can disable this status message by setting the Note Other AI code review bot(s) detectedCodeRabbit has detected other AI code review bot(s) in this pull request and will avoid duplicating their findings in the review comments. This may lead to a less comprehensive review. WalkthroughUpdated a blog post: corrected a Leaderboard hyperlink from Changes
Estimated code review effort🎯 1 (Trivial) | ⏱️ ~5 minutes Possibly related PRs
Suggested reviewers
Poem
Pre-merge checks and finishing touches✅ Passed checks (3 passed)
Comment |
Summary of ChangesHello @xslingcn, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request focuses on refining the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request updates a documentation link and adds an image to the flashinfer-bench.md blog post. The link update is correct, but I've pointed out another instance of the same link in the file that was missed. I've also suggested improving the accessibility of the newly added image by providing more descriptive alt text. Overall, these are minor changes to improve the post's correctness and accessibility.
| author: FlashInfer Community | ||
| --- | ||
| [**Leaderboard**](https://bench.flashinfer.ai) | [**FlashInfer Trace**](https://bench.flashinfer.ai/docs/flashinfer_trace/flashinfer_trace) | [**GitHub**](https://github.com/flashinfer-ai/flashinfer-bench) | ||
| [**Leaderboard**](https://bench.flashinfer.ai) | [**FlashInfer Trace**](https://bench.flashinfer.ai/docs/flashinfer-trace) | [**GitHub**](https://github.com/flashinfer-ai/flashinfer-bench) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for updating this link. However, it seems another instance of this link on line 101 was missed. Please update it as well to maintain consistency throughout the document.
The line in question is:
101: We provide standardized and clear documents for [FlashInfer Trace](https://bench.flashinfer.ai/docs/flashinfer_trace/flashinfer_trace) and [Op Types](https://bench.flashinfer.ai/docs/op_type_schema/gemm).| <figure> | ||
| <img src="/assets/imgs/flashinfer-bench/image16.png" alt="FlashInfer-Bench leaderboard screenshot" /> | ||
| </figure> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The alt text for this image is identical to the one for the image on line 152. To improve accessibility for users with screen readers, it's best practice to provide unique and descriptive alt text for each image that conveys its specific content. Please consider updating the alt text to describe what this particular image shows.
Summary by CodeRabbit