Attach backtrace signal handling with fl::init()#1132
Closed
jacobkahn wants to merge 8 commits intoflashlight:mainfrom
Closed
Attach backtrace signal handling with fl::init()#1132jacobkahn wants to merge 8 commits intoflashlight:mainfrom
jacobkahn wants to merge 8 commits intoflashlight:mainfrom
Conversation
facebook-github-bot
added
the
CLA Signed
jacobkahn
changed the title
jacobkahn
changed the title
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jacobkahn has updated the pull request. You must reimport the pull request before landing. |
|
@jacobkahn has updated the pull request. You must reimport the pull request before landing. |
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
1 similar comment
|
@jacobkahn has imported this pull request. If you are a Meta employee, you can view this diff on Phabricator. |
|
@jacobkahn merged this pull request in 7c6736d. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Downstream libs didn't properly initialize signal handling because the backward-cpp signal handler was a static in a C++ file and that could be loaded arbitrarily based on compilation options (static vs shared) and platforms.
Move signal handling init into
fl::init(), which now callsinitLogging()which conditionally callsinitBackward()if compiled to not be a noop.Also change the name of the directory from
common/backwardtocommon/stacktrace.Test plan: CI