-
Notifications
You must be signed in to change notification settings - Fork 168
Feature/exn monitoring database refactoring #505
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature/exn monitoring database refactoring #505
Conversation
|
We might also want to remove the CodeLine data pruning since it is no longer related to the exceptions. But at the other hand, if it is not referred to by any StackLines, there is no need to store it, so it could still be relevant just to clean up. Maybe it should just be done separately from the exception module, on another PR. |
|
The position of the |
I think it makes sense to move the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are some important comments that you should take a look at.
Specifically regarding the None check and the absence of truncation.
Otherwise really nice job! 🎖️
flask_monitoringdashboard/core/exceptions/stack_frame_parsing.py
Outdated
Show resolved
Hide resolved
incl None check, truncation, EOF errors, default non-captured bool, and function description
AlbertRossJoh
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🥇 🌪️ 🪨 🦆
Refactoring of the database. Specifically, how we store information about stack lines of exceptions.
(Obs also a minor change in ExceptionInfo: now it has a boolean telling if it was user captured)
The new database:

Close up of the ExceptionStackLine (and FunctionDefinition, CodeLine & StackTraceSnapshot) in the old database:

The old database:
