Skip to content

Conversation

@pothos
Copy link
Member

@pothos pothos commented Nov 11, 2025

The wrong variable was used to set up the mapping of the rclone config
into the rclone container and it wasn't set up in the right function.
Move it into the right function and use the right variable name but also
don't rely on /proc/PID/fd/FD to be mappable into the container but
instead use a regular temp file.

How to use

Cherry pick to the release branch and retag, then rerun the release job 🙃

Testing done

None!

@pothos pothos requested a review from a team as a code owner November 11, 2025 14:23
@pothos
Copy link
Member Author

pothos commented Nov 11, 2025

FYI, this was the error:

 Status: Downloaded newer image for rclone/rclone:1.71.1
 docker: Error response from daemon: create ****: "****" includes invalid characters for a local volume name, only "[a-zA-Z0-9][a-zA-Z0-9_.-]" are allowed. If you intended to pass a host directory, use absolute path
 
 Run 'docker run --help' for more information
 Finished with result: exit-code

Which I think comes from the wrong variable which had base64 content passed in, and as it's a secret it got masked with ****

@github-actions
Copy link

Build action triggered: https://github.com/flatcar/scripts/actions/runs/19268752860

The wrong variable was used to set up the mapping of the rclone config
into the rclone container and it wasn't set up in the right function.
Move it into the right function and use the right variable name but also
don't rely on /proc/PID/fd/FD to be mappable into the container but
instead use a regular temp file.

Signed-off-by: Kai Lueke <kailuke@microsoft.com>
Signed-off-by: Kai Lueke <kailuke@microsoft.com>
@pothos pothos merged commit cad1faf into main Nov 11, 2025
1 of 5 checks passed
@pothos pothos deleted the kai/release-rclone branch November 11, 2025 14:33
pothos added a commit that referenced this pull request Nov 11, 2025
ci-automation/release: Set up rclone config for mapping into container
pothos added a commit that referenced this pull request Nov 11, 2025
ci-automation/release: Set up rclone config for mapping into container
pothos added a commit that referenced this pull request Nov 12, 2025
ci-automation/release: Set up rclone config for mapping into container
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants