Add CI workflow#354
Merged
Merged
Conversation
Member
|
Thanks so much!
I just did that but we can discuss if we relax this for non-first contributors. |
pothos
reviewed
Jun 24, 2022
pothos
reviewed
Jun 24, 2022
pothos
approved these changes
Jun 24, 2022
Member
pothos
left a comment
There was a problem hiding this comment.
I think it's good to merge and then it gets easier to do changes.
15add06 to
29f1cb3
Compare
29f1cb3 to
6e03ea1
Compare
This was referenced Jun 27, 2022
Member
|
Will backport down to flatcar-3033 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add GitHub CI workflow
Currently the flatcar CI is not publicly viewable. this adds some friction for external contributors, as we rely on someone with access to jenkins, to shuttle information from the CI, into the PR.
This change adds a new workflow, that builds packages, the image and VM images, then uploads the resulting artifacts to github.
This is the first step in creating a set of workflows that are on par with what already exists in Jenkins. Next steps will include:
The current "glue" CI scripts were used as a base fr this workflow. Initially, this workflow sourced the existing scripts and called a function within those scripts, however, some changes were needed to work around the fact that there is no need to upload anything to bincache, and changing those existing scripts would have added a number of ugly special cases.
Cherry picking only needed bits helps keep the workflow clean, while allowing us to extend it with any future jobs or steps that might be needed, without working around old behavior.
How to use
This workflow will be run automatically on any pull request. To limit automatic workflow runs only to members of the team, change the repo settings under Settings --> Actions --> General --> "Fork pull request workflows from outside collaborators" --> "Require approval for all outside collaborators"
You can also run this workflow manually, by going to Action --> Run build --> Run Workflow. Running the workflow manually, also allows you to customize inputs.
Testing done
This change was tested in a fork. Results can be seen here:
https://github.com/gabriel-samfira/scripts/actions/runs/2553458796