Add zypak and update to 1.60.2#251
Conversation
|
Started test build 60164 |
|
Build 60164 successful |
|
Started test build 60726 |
|
Build 60726 successful |
|
|
||
| exec env PATH="${PATH}:${XDG_DATA_HOME}/node_modules/bin" \ | ||
| /app/extra/vscode/bin/code --extensions-dir=${XDG_DATA_HOME}/vscode/extensions "$@" ${WARNING_FILE} | ||
| exec env ELECTRON_RUN_AS_NODE=1 PATH="${PATH}:${XDG_DATA_HOME}/node_modules/bin" \ |
There was a problem hiding this comment.
What about patching /app/extra/vscode/bin/code to use zypak-wrapper? It seems like a better solution than bypassing upstream's wrapper script.
The Electron base app contains some useful Electron dependencies such as zypak. Using the base app can help reduce the duplication of dependencies. Co-authored-by: Teoh Han Hui <teohhanhui@gmail.com>
|
Started test build 61704 |
|
Build 61704 successful |
|
@bytzo @teohhanhui Can you folks ping me when you submit a PR and need a review/someone to merge? That might be the best way to proceed, as the app is not actively maintained. |
|
@barthalion Would you consider adding more maintainers? I'm not a Flatpak expert but I'd love to be able to help... I use vscode every day, if nothing else. |
4 participants
This pull request adds zypak and updates Visual Studio Code to 1.60.2. While there is already work on adding zypak in #237, it has been stale for almost two months and command line arguments do not appear to work.
In this pull request, command line arguments should still function properly with the exception of
--wait. I am unaware of a solution for this. Note that the--reuse-windowcommand line argument also does not function properly, however this issue exists in previous versions and is not caused by this pull request.This fixes #223 and fixes #247.