Add com.hoptodesk.HopToDesk #5514
Conversation
There was a problem hiding this comment.
There is an desktop file inside the deb
There was a problem hiding this comment.
It's true but it's malformed, and it doesn't pass lint checks. Therefore, I created an updated desktop file
There was a problem hiding this comment.
It includes new-window action that is not actually supported:
Actions=new-window;
X-Desktop-File-Install-Version=0.23
[Desktop Action new-window]
Name=Open a New Window
I removed this part to avoid alerts from flatpak-builder lint
There was a problem hiding this comment.
we just run desktop-file-validate on it.
hoptodesk.desktop: error: value "1.42.1" for key "Version" in group "Desktop Entry" is not a known version
hoptodesk.desktop: warning: value "Remote Desktop Software" for key "Comment" in group "Desktop Entry" looks the same as that of key "GenericName"
hoptodesk.desktop: error: required key "Exec" in group "Desktop Action new-window" is not present
There was a problem hiding this comment.
Exactly, that why I'm using a self-made desktop file
There was a problem hiding this comment.
These should be fixed, for now I guess it's fine.
bbhtt
added
the
awaiting-changes
Is this your project? If not did you contact upstream? |
It's not my project but the author asked me to help with Flathub submission |
Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>
com.hoptodesk.HopToDesk.json
Outdated
| "buildsystem" : "simple", | ||
| "sources" : [ | ||
| { | ||
| "url": "https://www.hoptodesk.com/hoptodesk.deb", |
There was a problem hiding this comment.
the .deb isn't versioned? This will be great to have the package not build at random times.
There was a problem hiding this comment.
also why isn't it built from source given that licensing isn't a problem. This would also allow supporting aarch64 at the same time.
Co-authored-by: Hubert Figuière <hub@figuiere.net>
…flathub into com.hoptodesk.HopToDesk
Co-authored-by: Hubert Figuière <hub@figuiere.net>
Co-authored-by: Hubert Figuière <hub@figuiere.net>
…Desk' into com.hoptodesk.HopToDesk
Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>
Co-authored-by: bbhtt <bbhtt.zn0i8@slmail.me>
|
bot, build com.hoptodesk.HopToDesk |
|
Queued test build for com.hoptodesk.HopToDesk. |
|
Started test build 141081 |
|
Build 141081 successful |
|
bot, build com.hoptodesk.HopToDesk |
|
Queued test build for com.hoptodesk.HopToDesk. |
|
Started test build 141472 |
|
Build 141472 successful |
bbhtt
added
ready
|
bot, build com.hoptodesk.HopToDesk |
|
Queued test build for com.hoptodesk.HopToDesk. |
|
Started test build 141608 |
|
Build 141608 successful |
|
/merge |
|
A repository for this submission has been created: https://github.com/flathub/com.hoptodesk.HopToDesk You will receive an invitation to be a collaborator which will grant you write access to the repository above. The invite can be also viewed here. If you've never maintained an app on Flathub before, common questions are answered in the app maintenance guide. If you're the original developer (or an authorized party), verify your app next to let users know it's coming from you. Please follow the Flathub blog for the latest announcements. Thanks! |
5 participants
Please confirm your submission meets all the criteria
Please describe the application briefly.
HopToDesk is a free remote desktop tool allowing users to share their screen, transfer files, and allow remote control access to their computers and devices using end-to-end encryption.
The domain used for the application ID is controlled by the application developers and the application id guidelines are followed.
I have read the and followed all the Submission and licence requirements.
I have built and tested the submission locally.
I am an author/developer/upstream contributor of the project. If not, I contacted upstream developers about this submission. Link: