Skip to content

Conversation

@eunos-1128
Copy link
Collaborator

This pull request simplifies the build process for the io.github.pemsley.coot.yaml file by removing unnecessary dependencies and updating the source commit. The most important changes include removing the monomer and reference-structure archives and updating the Git source commit.

Build process simplification:

  • Removed the monomer and reference-structure archives from the sources section, eliminating their associated URLs and SHA256 checksums. This simplifies the dependency management.
  • Updated the Git source commit to 21edc3a8c08602006a3d57f486444588f9326833 in the sources section to point to a newer version of the repository.
  • Adjusted the post-install section to remove operations related to the monomer and reference-structure directories, as they are no longer included in the build process.

@eunos-1128 eunos-1128 requested a review from Copilot June 6, 2025 17:01
@eunos-1128 eunos-1128 self-assigned this Jun 6, 2025
@flathubbot
Copy link

🚧 Test build enqueued.

@eunos-1128 eunos-1128 merged commit 76c529b into flathub:alpha Jun 6, 2025
1 check was pending
@flathubbot
Copy link

🚧 Started test build.

Copy link

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This pull request simplifies the build process by removing outdated dependencies and updating the Git source commit in the YAML manifest. Key changes include:

  • Removing commands that relocate the monomer and reference‐structure directories in the post-install section.
  • Eliminating archive dependency entries from the sources block.
  • Updating the Git commit to point to a newer repository version.
Comments suppressed due to low confidence (2)

io.github.pemsley.coot.yaml:334

  • Ensure that simply creating the '${FLATPAK_DEST}/share/coot/' directory fully replaces the functionality previously provided by moving the monomer and reference-structure directories. If these files are still needed elsewhere, consider adding comments or additional logic for clarity.
      - mkdir -p ${FLATPAK_DEST}/share/coot/

io.github.pemsley.coot.yaml:343

  • Verify that the updated Git commit correctly reflects all necessary changes now that the archive-based dependencies have been removed. Adding a brief comment in the YAML to indicate this intentional change could help future maintainers.
        commit: 21edc3a8c08602006a3d57f486444588f9326833

@flathubbot
Copy link

🚧 Test build succeeded. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/190481/io.github.pemsley.coot.flatpakref

@flathubbot
Copy link

Test build committed. To test this build, install it from the testing repository:

flatpak install --user https://dl.flathub.org/build-repo/190481/io.github.pemsley.coot.flatpakref

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants