Add 6.5 branch #196
Add 6.5 branch #196
Conversation
|
Started test build 49226 |
|
Build 49226 failed |
Does that mean I need to include a older ffmpeg version? |
|
Started test build 49236 |
|
Build 49236 successful |
| "-DQT_FEATURE_webengine_kerberos=ON", | ||
| "-DQT_FEATURE_webengine_proprietary_codecs=ON", | ||
| "-DQT_FEATURE_webengine_system_ffmpeg=ON", | ||
| "-DQT_FEATURE_webengine_system_ffmpeg=OFF", |
There was a problem hiding this comment.
The ffmpeg version of the runtime is not compatible with Chromium
There was a problem hiding this comment.
and it is in the 6.4 branch? That's odd, what's the error?
There was a problem hiding this comment.
This was explained here. There are 3 possible solutions:
- runtime patches ffmpeg
- baseapp patches webengine
- internal ffmpeg is used
There was a problem hiding this comment.
The thing is that 6.4 and 6.5 use the same freedesktop runtime. So if it works in 6.4 then it works in 6.5
Which is either 6.4 is broken or this should just be the same as 6.4
You can't expect that change in freedesktop runtime as 6.5 will not use a more recent runtime.
There was a problem hiding this comment.
May also be that 6.5 requires a newer ffmpeg.
Anyhow i think "internal ffmpeg is used" is good enough, if -DQT_FEATURE_webengine_system_ffmpeg=OFF does that no opposition from my side.
There was a problem hiding this comment.
So if it works in 6.4 then it works in 6.5
The webengine commit which blocks ffmpeg >= 5 (the problem is runtime ffmpeg is too new not too old) was introduced in 6.5.x branch. I don't know if 6.4 is silently broken or not affected.
Using internal ffmpeg should be just fine.
There was a problem hiding this comment.
As Erik555 said, it doesn't build with -DQT_FEATURE_webengine_system_ffmpeg=ON, so we need to disable that.
It is also highly possible, that this is also broken in the 6.4 branch. I assume they got a bug report, that it is not working, so they added this check.
|
Is there anything still prevent this from being merged? |
Nobody has said yes to my "Anyhow i think "internal ffmpeg is used" is good enough, if -DQT_FEATURE_webengine_system_ffmpeg=OFF does that no opposition from my side." yet. Or i missed it ^_^ |
|
yes, |
|
"I can't even say if this this even builds" "Is there anything still prevent this from being merged?" This is giving me a bit of conflicting information. Have you confirmed this at least builds or have you not? If you have not, what's preventing you to do it? |
It works. The buildbot has made a successfully testbuild. Did you miss the comment? |
|
Ok, i was hoping for something more than "it compiles" but i guess we could start with that... I just realized i can't commit here though :D |
|
let me create the branch then. |
|
Branch created. |
5 participants
This tries to add a 6.5 branch. I have edited the patch files local with a text editor (I don't know how to properly update them), so they don't throw a error any more., but I have no Idea what they do and I can't tell, if that was done right. I can't even say if this this even builds. If this builds and works, this needs to be merged in a new branch.