Unhandled exception when dispatching notfound w/async routing enabled.

[ChrisRus]

With patch noted in my previous issue post, my async routing test w/forward recursion is working okay. However, if I register the notfound handler I'm getting an exception. I'm investigating if notfound.

The problem is demonstrated on a snapshot deployment of the director.js test page I've been building. The snapshot is here: http://www.chrisrussell.net/html5/re-director3/

Note that you can see the exception in the router library when an unregistered route is processed. For example, go through the router boot steps after loading from this URL:

http://www.chrisrussell.net/html5/re-director3/#/NoneSuchRoute

I'll circle back when I figure out what's going on as this is currently blocking me from accomplishing what I need to do with director.js.

Thanks!

[ChrisRus]

P.S. If you folks like the direction I've been going with this little test harness, I'll gladly donate the code. The test page repo is here if you're interested: https://github.com/ChrisRus/re-director

[beaugunderson]

Ever figure this out? I'm hitting it now too.

[beaugunderson]

Hope to get a PR ready for a few other things but in lieu of that, here's the diff that fixes the issue:

@@ -422,7 +422,7 @@ Router.prototype.invoke = function (fns, thisArg, callback) {
         return _asyncEverySeries(fn, apply, next);
       }
       else if (typeof fn == 'function') {
-        fn.apply(thisArg, fns.captures.concat(next));
+        fn.apply(thisArg, (fns.captures || []).concat(next));
       }
     };
     _asyncEverySeries(fns, apply, function () {

[beaugunderson]

Wow, there was already a PR for this (#187) which I've just merged. I'll check out re-director as well, thanks for the link. ✨