modifying Array.prototype in browser.js breaks array iteration code in IE

[exortech]

Any code that iterates an array but isn't doing a hasOwnProperty check is going to break due to the addition of the filter function. Modifying the array prototype, especially in client-side code, is not recommended as it will break code in older browsers not designed to handle it.

[indexzero]

@exortech Do you have examples of where we do this in the code so we can fix them?

[exortech]

Sorry, I should have been more explicit. It's at the top of browser.js

Array.prototype.filter = function(filter, that) {
...
}

Array.isArray = function(obj) {
...
};

[beaugunderson]

Huge +1 on this. All non-obsolete browsers support both these methods now. If someone wants to support older browsers they can use a shim to do so themselves.