fix http route recursion#228
fix http route recursion#2283rd-Eden merged 2 commits intoflatiron:masterfrom shadedyin:http-recursion
Conversation
|
I suspected my changes may have had unexpected consequences. Fortunately the breakage seems minor and specific. |
|
@psev Any reason you closed this? I'd like to merge it. |
|
Any update on this? Any reason it hasn't been merged? |
|
Thanks for your contribution. <3 |
|
Wow, I can't remember what I was thinking when I closed this, my apologies. I thoroughly went through Director's source and really liked what I saw. I found a problem with recursively calling the path function so I set about fixing a few minor issues, which eventually turned into a complete rewrite. You can see that Elixir.js is entirely based on the Director git repository. The utility functions at the beginning of router.js have been factored and reworked into RaptorJuice.js, which also includes lightweight generators/iterators. Director turned into Elixir.js, which builds solely upon RaptorJuice. Both projects are very thoroughly documented, tested and above 98% code coverage. Only a few lines need to be changed for javascript isomorphism. I'll get back to it eventually, I've just been way busy with a new DevOps job. |
Not much to it. Oh, and I wrote you a unit test to add to your collection.