Add --install argument #81
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
alexlarsson
added a commit
to alexlarsson/flatpak
that referenced
this pull request
Dec 13, 2017
This is a no-op on regular (archive) repos, but on bare repos it is an optimization if the source is a checkout from the repo. This happens in flatpak-builder (flatpak/flatpak-builder#81) when it commits the build to the cache during --install without --repo.
rh-atomic-bot
pushed a commit
to flatpak/flatpak
that referenced
this pull request
Dec 14, 2017
This is a no-op on regular (archive) repos, but on bare repos it is an optimization if the source is a checkout from the repo. This happens in flatpak-builder (flatpak/flatpak-builder#81) when it commits the build to the cache during --install without --repo. Closes: #1249 Approved by: alexlarsson
This allows you to build and install the result in a single operation. If a --repo is given the app is installed from there, otherwise we build-export it to the flatpak-builder cache repo, which already has all the objects that are needed in it, so this will not increase disk-use.
Member
Author
|
📌 Commit cdb0368 has been approved by |
|
⚡ Test exempted: pull fully rebased and already tested. |
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 14, 2017
Closes: #81 Approved by: alexlarsson
rh-atomic-bot
pushed a commit
that referenced
this pull request
Dec 14, 2017
This allows you to build and install the result in a single operation. If a --repo is given the app is installed from there, otherwise we build-export it to the flatpak-builder cache repo, which already has all the objects that are needed in it, so this will not increase disk-use. Closes: #81 Approved by: alexlarsson
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows you to build and install the result in a single operation. If a --repo is given the app is installed from there, otherwise we build-export it to the flatpak-builder cache repo, which already has all the objects that are needed in it, so this will not increase disk-use.
Note, this is WIP, because we depend on flatpak/flatpak#1244, as well as having merged #80 into the PR. Once we have these in officially we can rebase the PR.