Closed
Conversation
As seen in flatpak#2829, the system-helper crashes while trying to access an as parameter as s. Looking at the likely culprits for this, I find that the permission check for Deploy has an off-by-one error where it tries to get the installation, but passes the offset for the previous_ids parameter.
Contributor
|
I can confirm this patch seems to fix that part of my report. |
Collaborator
Author
|
I got another confirmation for this fix, so |
|
📌 Commit 9647c95 has been approved by |
|
⚡ Test exempted: merge already tested. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As seen in #2829, the system-helper crashes while trying to access an as parameter as s. Looking at the likely culprits for this, I find that the permission check for Deploy has an off-by-one error where it tries to get the installation, but passes the offset for the previous_ids parameter.
It would be less error-prone to use introspection data and refer to parameters by name here.