system-helper: Add appstream-update to privileged group polkit rules#6501
Closed
valankar wants to merge 1 commit intoflatpak:mainfrom
Closed
system-helper: Add appstream-update to privileged group polkit rules#6501valankar wants to merge 1 commit intoflatpak:mainfrom
valankar wants to merge 1 commit intoflatpak:mainfrom
Conversation
Contributor
|
can you make the commit message something like |
valankar
changed the title
Author
|
Updated, not sure if that looks better though. |
Contributor
|
No, you added a merge commit and introduced unrelated indentation changes. |
appstream-update is required to do flatpak update --apstream. When executed via arch-update inside a systemd service/timer, the update was failing due to this action not being allowed.
Author
|
Sorry do you still need me to do something here? I asked github copilot to address the comments and it seemed to do that merge commit nonsense. Fantastic AI. I don't really care about this too much as I've worked around it by now. This config is clearly wrong to begin with, and if no one else cares I'm happy to close. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It appears appstream-update is required to do
flatpak update --apstream. I was trying to run this (via arch-update) in a systemd service/timer and after debugging found it was failing due to this action not being allowed.I think it makes sense to add it.