fix(docker): Use Docker SDK for startup check and compose-go#93
Merged
Conversation
Replace exec.Command("docker", "info") with moby/moby client
Ping() with 5s timeout for Docker reachability. Remove global
os.Setenv("DOCKER_HOST"); pass socket via client.WithHost().
Replace CLI-based compose validation with compose-go/v2 SDK
for in-process validation. Add validation to updateDeployment.
Keep CLI docker context inspect for socket discovery since SDK
does not resolve Docker Desktop contexts.
Update deployments_path default: ~/flatrun/deployments with
fallback to /var/lib/flatrun/deployments. Expand ~ in config.
Co-Authored-By: austin047 <fuhaustin@gmail.com>
Signed-off-by: nfebe <fenn25.fn@gmail.com>
nfebe
force-pushed
the
fix/docker-startup-recommended
branch
from
caa8331 to
418ba9e
Compare
Code Review SummaryThis PR modernizes Docker interaction by moving from CLI exec calls to the Moby and Compose SDKs. It also improves environment detection for Docker Desktop users and adds proper validation to the deployment update flow. 🚀 Key Improvements
💡 Minor Suggestions
|
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replace exec.Command("docker", "info") with moby/moby client Ping() with 5s timeout context for Docker reachability check. Remove os.Setenv("DOCKER_HOST") global side effect; pass socket explicitly via client.WithHost().
Replace CLI-based compose validation (docker compose config) with compose-go/v2 SDK for in-process validation without temp files or subprocess overhead. Add validation to updateDeployment handler.
Use CLI-based detectDockerHost() with docker context inspect for socket discovery since the SDK does not resolve Docker Desktop contexts (hardcodes unix:///var/run/docker.sock).
Update deployments_path default: ~/flatrun/deployments with fallback to /var/lib/flatrun/deployments. Expand ~ in config. Add __debug_bin* and deployments/ to .gitignore.