feat(cli): Add setup command for infrastructure deployment#98
Conversation
Adds `flatrun-agent setup infra <service>` CLI command that deploys infrastructure services from embedded templates. Validates that the requested template is a valid infrastructure type, uses programmatic Docker and network APIs, and creates all required config files. Currently supports nginx. Extensible for future services. Signed-off-by: nfebe <fenn25.fn@gmail.com>
Code Review SummaryThis PR introduces a robust 🚀 Key Improvements
💡 Minor Suggestions
|
Move setup wizard logic from internal/api/setup_handlers.go into a clean internal/setup/ package with proper separation of concerns: - manager.go: state management, IP resolution, config access - validation.go: system checks (Docker, disk, memory, ports) - handlers.go: HTTP handlers wrapping Manager + auth.Manager All 15 tests pass. Server routes rewired to use new package. Signed-off-by: nfebe <fenn25.fn@gmail.com>
![sourceant[bot]](https://avatars.githubusercontent.com/in/1161781?s=60&v=4){kind=small}
| return check | ||
| } | ||
|
|
||
| func IsPortAvailable(port int) bool { |
There was a problem hiding this comment.
Testing port availability by attempting to bind to 0.0.0.0 and 127.0.0.1 sequentially might fail if the OS considers 0.0.0.0 as covering 127.0.0.1. It's more reliable to check 0.0.0.0 (all interfaces) or use a library that checks netstat/ss state if accuracy across all interfaces is needed without race conditions.
| func IsPortAvailable(port int) bool { | |
| func IsPortAvailable(port int) bool { | |
| ln, err := net.Listen("tcp", ":"+strconv.Itoa(port)) | |
| if err != nil { | |
| return false | |
| } | |
| _ = ln.Close() | |
| return true | |
| } |
Replace hardcoded writeNginxFiles/writeInfraTemplateFiles with a generic writeSetupFiles that reads dirs and files from metadata.yml. New infra templates only need metadata — no per-template Go code. Port checks now handle systems with IPv6 disabled by testing IPv6 support before treating bind failures as "port in use." Signed-off-by: nfebe <fenn25.fn@gmail.com>
| if req.AutoSSL != nil { | ||
| cfg.Domain.AutoSSL = *req.AutoSSL | ||
| } | ||
| if len(req.CORSOrigins) > 0 { |
There was a problem hiding this comment.
When appending new CORS origins, it's safer to ensure they are valid URLs and handled in a way that doesn't create duplicate entries if the config is already partially populated. The current implementation uses a map to deduplicate within the request, which is good, but doesn't check for URL validity.
| if len(req.CORSOrigins) > 0 { | |
| if len(req.CORSOrigins) > 0 { | |
| originMap := make(map[string]bool) | |
| for _, e := range cfg.API.AllowedOrigins { | |
| originMap[e] = true | |
| } | |
| for _, origin := range req.CORSOrigins { | |
| origin = strings.TrimRight(origin, "/") | |
| if !originMap[origin] { | |
| cfg.API.AllowedOrigins = append(cfg.API.AllowedOrigins, origin) | |
| originMap[origin] = true | |
| } | |
| } | |
| } |
1 participant
Adds
flatrun-agent setup infra <service>CLI command that deploys infrastructure services from embedded templates. Validates that the requested template is a valid infrastructure type, uses programmatic Docker and network APIs, and creates all required config files.Currently supports nginx. Extensible for future services.