-
Notifications
You must be signed in to change notification settings - Fork 0
feat(ui): Add multi-domain management UI #44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
nfebe
commented
Jan 31, 2026
- Add DomainsManager component for multi-domain table view
- Add DomainFormModal for creating/editing domains
- Add domain CRUD API methods to deploymentsApi
- Update DeploymentDetailView with unified handleDeleteDomain
- Add hasMultipleDomains and singleDomainId computed properties
- Add tests for domain-related computed properties
Code Review SummaryThis pull request introduces a comprehensive multi-domain management feature for deployments, significantly enhancing the flexibility of domain configurations. It involved creating two new components, 🚀 Key Improvements
💡 Minor Suggestions
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. See the overview comment for a summary.
Deploying flatrun-ui with
|
| Latest commit: |
f01a901
|
| Status: | ✅ Deploy successful! |
| Preview URL: | https://a6ed65e4.flatrun-ui.pages.dev |
| Branch Preview URL: | https://feat-multi-domain-support.flatrun-ui.pages.dev |
- Add DomainsManager component for multi-domain table view - Add DomainFormModal for creating/editing domains - Add domain CRUD API methods to deploymentsApi - Update DeploymentDetailView with unified handleDeleteDomain - Add hasMultipleDomains and singleDomainId computed properties - Add tests for domain-related computed properties Signed-off-by: nfebe <fenn25.fn@gmail.com>
- Add DatabaseConfig interface to types - Add advanced options in Compose Mode for multi-domain/database - Add dynamic wizard steps based on advanced options selection - Add Domains step for routing domains to different services - Add multi-database UI in Database step with add/remove support - Display database configs in DeploymentDetailView - Update handleCreate to send domains and databases arrays - Add comprehensive type tests for new interfaces Signed-off-by: nfebe <fenn25.fn@gmail.com>
fe6199b to
f01a901
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review complete. No specific code suggestions were generated. See the overview comment for a summary.