Skip to content

Conversation

@nfebe
Copy link
Contributor

@nfebe nfebe commented Jan 31, 2026

  • Add DomainsManager component for multi-domain table view
  • Add DomainFormModal for creating/editing domains
  • Add domain CRUD API methods to deploymentsApi
  • Update DeploymentDetailView with unified handleDeleteDomain
  • Add hasMultipleDomains and singleDomainId computed properties
  • Add tests for domain-related computed properties

@sourceant
Copy link

sourceant bot commented Jan 31, 2026

Code Review Summary

This pull request introduces a comprehensive multi-domain management feature for deployments, significantly enhancing the flexibility of domain configurations. It involved creating two new components, DomainFormModal.vue and DomainsManager.vue, and integrating them into DeploymentDetailView.vue. The changes also include updates to API services and types to support the new domain structure. Overall, the implementation is clean and well-structured, improving modularity and user experience for domain management.

🚀 Key Improvements

  • Modularized domain management into DomainsManager.vue and DomainFormModal.vue.
  • Added support for managing multiple domains and aliases per deployment.
  • Improved clarity for domain configuration in DeploymentDetailView.vue by separating single- and multi-domain views.
  • Updated API interfaces and types to reflect new domain management capabilities.

💡 Minor Suggestions

  • Review the handleAddDomain logic in DeploymentDetailView.vue to prevent potential duplicate entries when migrating legacy domains.
  • Ensure strict type consistency for the id field in DomainConfig during creation operations (i.e., omit id instead of providing an empty string).

Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. See the overview comment for a summary.

@cloudflare-workers-and-pages
Copy link

cloudflare-workers-and-pages bot commented Jan 31, 2026

Deploying flatrun-ui with  Cloudflare Pages  Cloudflare Pages

Latest commit: f01a901
Status: ✅  Deploy successful!
Preview URL: https://a6ed65e4.flatrun-ui.pages.dev
Branch Preview URL: https://feat-multi-domain-support.flatrun-ui.pages.dev

View logs

nfebe added 2 commits January 31, 2026 18:47
- Add DomainsManager component for multi-domain table view
- Add DomainFormModal for creating/editing domains
- Add domain CRUD API methods to deploymentsApi
- Update DeploymentDetailView with unified handleDeleteDomain
- Add hasMultipleDomains and singleDomainId computed properties
- Add tests for domain-related computed properties

Signed-off-by: nfebe <fenn25.fn@gmail.com>
- Add DatabaseConfig interface to types
- Add advanced options in Compose Mode for multi-domain/database
- Add dynamic wizard steps based on advanced options selection
- Add Domains step for routing domains to different services
- Add multi-database UI in Database step with add/remove support
- Display database configs in DeploymentDetailView
- Update handleCreate to send domains and databases arrays
- Add comprehensive type tests for new interfaces

Signed-off-by: nfebe <fenn25.fn@gmail.com>
@nfebe nfebe force-pushed the feat/multi-domain-support branch from fe6199b to f01a901 Compare January 31, 2026 17:48
Copy link

@sourceant sourceant bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review complete. No specific code suggestions were generated. See the overview comment for a summary.

@nfebe nfebe merged commit f12a063 into main Jan 31, 2026
5 checks passed
@nfebe nfebe deleted the feat/multi-domain-support branch January 31, 2026 22:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants