Fix MoneyInput component state management issues #105
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove conflicting @value binding from Input helper to give AutoNumeric sole control - Add did-update modifier to reactively sync external value changes - Implement handleValueChanges action to update AutoNumeric when @value changes - Add rawValueDivisor: 100 option to handle cents/dollars conversion natively - Remove internal @Tracked value property and rely on @args.value as single source of truth - Switch to autoNumeric:rawValueModified event for more accurate change detection - Simplify onChange callback to pass raw value directly - Update setCurrency to use autonumeric.update() instead of set() This fixes the issue where MoneyInput would not update when the bound value changed, causing stale values to persist when forms were reused without page refresh.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes the issue where MoneyInput would not update when the bound value changed, causing stale values to persist when forms were reused without page refresh.