Merged
Conversation
getvictor
force-pushed
the
victor/fixing-configs
branch
from
2721e1d to
f4cae1a
Compare
3 tasks
noahtalerman
requested changes
Feb 8, 2024
|
|
||
| 6. Push your cloned and modified code to your repo. | ||
|
|
||
| 7. In GitHub, enable the `Apply latest configuration to Fleet` GitHub Actions workflow, and run workflow manually. Now, when anyone pushes a new commit, the action will run and update Fleet. In addition, the workflow will run every 24 hours to ensure that the Fleet configuration is in sync with your git repo. |
Member
There was a problem hiding this comment.
Suggested change
| 7. In GitHub, enable the `Apply latest configuration to Fleet` GitHub Actions workflow, and run workflow manually. Now, when anyone pushes a new commit, the action will run and update Fleet. In addition, the workflow will run every 24 hours to ensure that the Fleet configuration is in sync with your git repo. | |
| 7. In GitHub, enable the `Apply latest configuration to Fleet` GitHub Actions workflow, and run workflow manually. Now, when anyone pushes a new commit, the action will run and update Fleet. |
I see what you're after with this! If any change is made outside of the repo (UI/API/fleetctl), Fleet will get reset (sync w/ the repo).
I think we can cut this feature for v1.
Why? I think it adds more UX complexity. More for the user to keep track of and more for us to explain.
The user can manually trigger the GitHub action if they want to sync right? If so, I think starting w/o the automated run every 24 hours is simpler. The action runs on merge and when you trigger it.
We can get fancy later.
noahtalerman
approved these changes
Feb 8, 2024
Member
noahtalerman
left a comment
noahtalerman
left a comment
There was a problem hiding this comment.
YAML interface and README look good to me!
I'll lean on y'all to review the workflow and file and bash script.
Member
|
Hey @getvictor I think we should make you the CODEOWNER of the workflow file and bash script so you get pinged anytime someone wants to make a change. What do you think? I can be CODEOWNERS of the README + YAML files + lib/ If you're cool with that can you please open a PR to CODEOWNERS? |
lucasmrod
reviewed
Feb 9, 2024
getvictor
added a commit
to fleetdm/fleet
that referenced
this pull request
Feb 9, 2024
Add `fleetctl gitops` command for #13643 Code review video: https://www.loom.com/share/7941c51c709b44ccafd618dd05837d99?sid=27b923d7-1393-4396-bac7-30616b2d6de9 fleet-gitops PR that also needs review: fleetdm/fleet-gitops#26 Working global/team gitops configs that can be used for testing: https://github.com/fleetdm/fleet-gitops/tree/victor/fixing-configs # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
georgekarrv
pushed a commit
to fleetdm/fleet
that referenced
this pull request
Feb 13, 2024
Add `fleetctl gitops` command for #13643 Code review video: https://www.loom.com/share/7941c51c709b44ccafd618dd05837d99?sid=27b923d7-1393-4396-bac7-30616b2d6de9 fleet-gitops PR that also needs review: fleetdm/fleet-gitops#26 Working global/team gitops configs that can be used for testing: https://github.com/fleetdm/fleet-gitops/tree/victor/fixing-configs # Checklist for submitter If some of the following don't apply, delete the relevant line. <!-- Note that API documentation changes are now addressed by the product design team. --> - [x] Changes file added for user-visible changes in `changes/` or `orbit/changes/`. - [x] Added/updated tests - [x] Manual QA for all new/changed functionality
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added GitHub action workflow.
@lucasmrod Please review README.md, workflow.yml, and workflow.sh files
Also, updated indentation to be consistent.