Latest orbit fails to auto-update on Windows

[lucasmrod]

Fleetd version: stable (v1.6.0)

---

Push a new version of Orbit executable for Windows to a TUF server.

🧑‍💻  Expected behavior

Orbit is eventually auto-updated on Windows.

💥  Actual behavior

Orbit cannot auto-update, the update routine fails every time with the following error:

2023-03-03T18:46:43-03:00 INF update failed error="check symlink failed: read existing symlink:
readlink C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe: The file or directory is not a reparse point."

More info

Guess: The issue seems related to a recent fix: #9188.

[lucasmrod]

@xpkoala Please check if you can reproduce:

fleetctl package --type=msi --fleet-desktop --fleet-url=<...> --enroll-secret=<...> --insecure --update-interval 10s

And then check logs in C:\Windows\system32\config\systemprofile\AppData\Local\FleetDM\Orbit\Logs\orbit-osquery.log, the following should be printed every 10 seconds:

2023-03-03T18:46:43-03:00 INF update failed error="check symlink failed: read existing symlink:
readlink C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe: The file or directory is not a reparse point."

Which means that when using a custom TUF server you won't be able to auto-update the orbit.exe executable. (Please double check this just to be extra sure.)

[ksatter]

@lucasmrod I was able to reproduce:

Windows 10 Pro 10.0.19045 Build 19045

2023-03-06T10:03:46-06:00 INF update failed error="check symlink failed: read existing symlink: readlink C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe: The file or directory is not a reparse point."
2023-03-06T10:03:56-06:00 INF update failed error="check symlink failed: read existing symlink: readlink C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe: The file or directory is not a reparse point."
2023-03-06T10:04:06-06:00 INF update failed error="check symlink failed: read existing symlink: readlink C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe: The file or directory is not a reparse point."
2023-03-06T10:04:16-06:00 INF calling flags update

[marcosd4h]

I was able to reproduce it too on a clean Win10 Pro installation

OS Version - 10.0.19045.2604

2023-03-06T08:10:34-08:00 INF hash(orbit)=bb312d067fc7d6920db514a1660dbc54c4d4b1e66619721f3eb1055325f9374d0c49d962fb5f4e484b8dd0fff4f99d3ee67e3ea8713337fa68a2f60a6bec13a3
2023-03-06T08:10:34-08:00 INF hash(osqueryd)=3b673b843e49c24dfd77d62ca650b308e332a2922da1ab7610c8b8e3265c0cd51d7575f00dd329efadb1f887883041f83dbde769eaa7c0a11fed3b8394b115c7
2023-03-06T08:10:35-08:00 INF hash(desktop)=bdc45d4df0cfe9e378910931004c734ca2687eac7e4fe8e53c9e475a84f3ededf35414ab2585519827062249c51d042eec5cab8d2ba9a6b3a6c343b0440e7b7f
2023-03-06T08:10:37-08:00 DBG found expected target locally path="C:\\Program Files\\Orbit\\bin\\orbit\\windows\\stable\\orbit.exe" target=orbit
2023-03-06T08:10:37-08:00 INF early update check failed error="check symlink failed: read existing symlink: readlink C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe: The file or directory is not a reparse point."
2023-03-06T08:10:37-08:00 DBG found expected target locally path="C:\\Program Files\\Orbit\\bin\\osqueryd\\windows\\stable\\osqueryd.exe" target=osqueryd
2023-03-06T08:10:37-08:00 DBG found expected target locally path="C:\\Program Files\\Orbit\\bin\\desktop\\windows\\stable\\fleet-desktop.exe" target=desktop
2023-03-06T08:10:37-08:00 DBG running single query (SELECT uuid FROM system_info)
2023-03-06T08:10:37-08:00 DBG UUID source was UUID_Source_WMI.

[marcosd4h]

I've just confirmed that removing PR #9188 fixes the issue.

2023-03-06T09:17:53-08:00 INF hash(osqueryd)=3b673b843e49c24dfd77d62ca650b308e332a2922da1ab7610c8b8e3265c0cd51d7575f00dd329efadb1f887883041f83dbde769eaa7c0a11fed3b8394b115c7
2023-03-06T09:17:53-08:00 INF hash(desktop)=bdc45d4df0cfe9e378910931004c734ca2687eac7e4fe8e53c9e475a84f3ededf35414ab2585519827062249c51d042eec5cab8d2ba9a6b3a6c343b0440e7b7f
2023-03-06T09:17:54-08:00 INF update detected target=orbit
2023-03-06T09:17:54-08:00 DBG stat file error="CreateFile C:\\Program Files\\Orbit\\bin\\orbit\\windows\\edge\\orbit.exe: The system cannot find the path specified."
2023-03-06T09:18:02-08:00 INF update completed target=orbit
2023-03-06T09:18:02-08:00 DBG no update target=osqueryd
2023-03-06T09:18:02-08:00 DBG no update target=desktop
2023-03-06T09:18:02-08:00 INF exiting due to successful early update
2023-03-06T09:18:04-08:00 INF hash(orbit)=14c14e9233543b89fb90b239dd779cdfc44a73c87b191ef3451f1ef2ec2080b229c889a9cd796f022667dc5805779ddc9277b9d40aab9c8f7ac0cf3a9218e6ce
2023-03-06T09:18:04-08:00 INF hash(osqueryd)=3b673b843e49c24dfd77d62ca650b308e332a2922da1ab7610c8b8e3265c0cd51d7575f00dd329efadb1f887883041f83dbde769eaa7c0a11fed3b8394b115c7
2023-03-06T09:18:05-08:00 INF hash(desktop)=bdc45d4df0cfe9e378910931004c734ca2687eac7e4fe8e53c9e475a84f3ededf35414ab2585519827062249c51d042eec5cab8d2ba9a6b3a6c343b0440e7b7f
2023-03-06T09:18:05-08:00 DBG found expected target locally path="C:\\Program Files\\Orbit\\bin\\orbit\\windows\\edge\\orbit.exe" target=orbit
2023-03-06T09:18:05-08:00 DBG no update target=orbit
2023-03-06T09:18:05-08:00 DBG no update target=osqueryd
2023-03-06T09:18:05-08:00 DBG no update target=desktop
2023-03-06T09:18:05-08:00 DBG found expected target locally path="C:\\Program Files\\Orbit\\bin\\osqueryd\\windows\\stable\\osqueryd.exe" target=osqueryd
2023-03-06T09:18:05-08:00 DBG found expected target locally path="C:\\Program Files\\Orbit\\bin\\desktop\\windows\\stable\\fleet-desktop.exe" target=desktop
2023-03-06T09:18:05-08:00 DBG cleaned up old path="C:\\Program Files\\Orbit\\bin\\orbit\\orbit.exe.old"
2023-03-06T09:18:05-08:00 DBG running single query (SELECT uuid FROM system_info)
2023-03-06T09:18:06-08:00 DBG UUID source was UUID_Source_WMI.