Hide automatically-created (Fleet-created/maintained) policies in Policies list

[eugkuo]

Goal

User story
As an admin,
I want to not see Fleet-created policies in the Policies list
so that I can not be confused by policies that don't adhere to my naming convention or that seem to appear out of nowhere.

Key result

Every sprint, ship small UX improvements based on dogfooding or customer feedback

Original requests

None

Context

• Product designer: @eugkuo

Changes

Product

• UI changes:
  • Host detail: Show Fleet-created with toggle to hide
    • 1440
    • 990
    • 880
    • 768
    • 650
    • 576
    • 480
    • 360
  • Policies landing: Show Fleet-created with toggle to hide
    • 1440
    • 990
    • 880
    • 768
    • 650
    • 576
    • 480
    • 360
  • Automations modal: Show Fleet-created with toggle to hide
    • 1440 to 880
    • 768
    • 650, 576
    • 480
    • 360
  • Automatic install modal
    • 1440 to 880
    • 768
    • 650, 576
    • 480
    • 360
  • Software details: Show 100% of the time
  • My device page: Hide 100% of the time
• CLI (fleetctl) usage changes: TODO
• YAML changes: TODO
• REST API changes: TODO
• Fleet's agent (fleetd) changes: TODO
• Activity changes: TODO
• Permissions changes: TODO
• Changes to paid features or tiers: TODO
• Transparency changes: TODO
• First draft of test plan added
• Other reference documentation changes: TODO
• Once shipped, requester has been notified
• Once shipped, dogfooding issue has been filed

Engineering

• Test plan is finalized
• Feature guide changes: TODO
• Database schema migrations: TODO
• Load testing: TODO

ℹ️  Please read this issue carefully and understand it. Pay special attention to UI wireframes, especially "dev notes".

QA

Risk assessment

• Requires load testing: TODO
• Risk level: Low / High TODO
• Risk description: TODO

Test plan

1. Add a Fleet-maintained app and choose "Automatic install."
2. Navigate to the "Policies" page.
3. Ensure the "[Install software] software name" policy does not appear
4. Repeat 1-3 with custom packages and App Store apps

Testing notes

Confirmation

1. Engineer: Added comment to user story confirming successful completion of test plan.
2. QA: Added comment to user story confirming successful completion of test plan.

[eugkuo]

I've added the following to this ticket which shows a before and after of the policies page.:

• Figma link

I'm not sure if other changes need be made?

[eugkuo]

I realized I should have put my question in the ticket re: whether we need API changes for this.

@iansltx indicated there are, because we need to mark policies as Fleet-created so we know which to hide.

So . . does this mean that under ‘add policy’ in the API docs we should add a parameter called something like creator?

Name	Type	In	Description
creator	string	body	Indicates the creator of the policy. Currently-supported value is "fleet"

FYI @jmwatts @noahtalerman

[iansltx]

We wouldn't expose this in the Add policy endpoint as something user-editable, but we would either need a filter parameter for the policy list endpoint (for filtering server-side) or a flag on the policy response (for filtering/visually differentiating client-side). Preferably both. But Fleet would manage this internally when handling the "add an installer/VPP app" request (or soon "edit an installer/VPP app") rather than needing the API client to explicitly set this.

[iansltx]

I've added the following to this ticket which shows a before and after of the policies page.:

• Figma link

I'm not sure if other changes need be made?

Visibility change pls

[eugkuo]

Had a conversation with @iansltx during design review and came up with the following. Designs are included where the UI will need to be updated.

• Host detail: Show Fleet-created with toggle to hide
  • 1440
• Policies landing: Show Fleet-created with toggle to hide
  • 1440
• Automations modal: Show Fleet-created with toggle to hide
  • 1440
• Software details: Show 100% of the time to let people know this is a thing that exists
• My device page: Hide it here; no need to show users what's under the hood

FYI @noahtalerman @mostlikelee @jmwatts

[iansltx]

maybe Fleet-managed rather than Fleet-created, so we have Fleet-managed apps and Fleet-managed policies and we use "managed" as code for "don't touch this it's our problem." Which we can extend to telling users that if they edit a policy then they're taking that policy over and it's their problem now (we're discussing doing the same with FMA for the pieces of FMA that we manage, namely install package + install/uninstall scripts).

[iansltx]

Otherwise LGTM since it gives the people who should be able to see the wole picture the ability to see the whole picture, and we can have those policies invisible by default.

[eugkuo]

maybe Fleet-managed rather than Fleet-created, so we have Fleet-managed apps and Fleet-managed policies and we use "managed" as code for "don't touch this it's our problem." Which we can extend to telling users that if they edit a policy then they're taking that policy over and it's their problem now (we're discussing doing the same with FMA for the pieces of FMA that we manage, namely install package + install/uninstall scripts).

@iansltx Works for me. Updated text to read "Fleet-managed."