generate-gitops does not respect changes made via UI to the VPP token team assignments

[AndreyKizimenko]

Fleet version: 4.74

Web browser and operating system: N/A

---

💥  Actual behavior

TODO

The teams in the default.yml file are not the ones that were set in the UI, they are the ones that were set on the previous gitops run

Also confirmed to be the case on 4.73.1

🛠️ To fix

generate-gitops should respect the changes to the VPP token team assignments made in the UI

Product designer: @rachaelshaw

🧑‍💻  Steps to reproduce

1. Upload vpp token
2. Assign teams via the UI
3. Run generate gitops
4. No teams are added in default.yml for vpp token
5. Add some teams to the VPP token in the default.yml file
6. Run gitops
7. It sets them to what’s in the default.yml
8. Change them in the UI
9. Run generate gitops

🕯️ More info (optional)

N/A

[iansltx]

Planning poker

[sgress454]

Just ran into this. I suspect that what's happening here is that when we run fleetctl gitops we parse the vpp config from the yaml files and do whatever's required on the backend to apply that config, but we also persist the config values into the app_config_json. The UI doesn't modify the JSON because it's not the actual source of truth for this config. And unless we tell it otherwise, fleetctl generate-gitops just outputs whatever's in that JSON. So the fix is to put code in generate-gitops that calls the /vpp_tokens endpoint to get the actual config rather than reading it from mdm.volume_purchasing_program.

[sgress454]

I ended up putting a branch together for this, I'll get up a PR when I have the chance but just posting here so no one duplicates the work.