Website 5XX Error

[rfairburn]

---

💥  Actual behavior

The following appeared in the logs:

Nov 21 09:23:28 AM   <- GET /tables/authenticode                   (26ms 200)
Nov 21 09:23:28 AM    °
Nov 21 09:23:29 AM   <- POST /api/v1/webhooks/receive-usage-analytics  (6ms 200)
Nov 21 09:23:29 AM    °
Nov 21 09:23:29 AM   error: Sending 500 ("Server Error") response:
Nov 21 09:23:29 AM    PreconditionFailedError: Precondition Failed
Nov 21 09:23:29 AM       at createHttpError (/app/node_modules/send/index.js:978:12)
Nov 21 09:23:29 AM       at SendStream.error (/app/node_modules/send/index.js:270:31)
Nov 21 09:23:29 AM       at SendStream.send (/app/node_modules/send/index.js:627:12)
Nov 21 09:23:29 AM       at onstat (/app/node_modules/send/index.js:724:10)
Nov 21 09:23:29 AM       at FSReqCallback.oncomplete (node:fs:199:5)
Nov 21 09:23:29 AM   <- POST /api/v1/webhooks/github               (5ms 200)
Nov 21 09:23:29 AM    °
Nov 21 09:23:29 AM   <- GET /tables/windows_security_products      (27ms 200)
Nov 21 09:23:29 AM    °

However, the logs didn't appear to to also include a URL with a 500 response around it. As such I've included the closest 2 requests before and after that reported 200s by timestamp in case they are related.

🛠️ To fix

TODO

🧑‍💻  Steps to reproduce

These steps:

• Have been confirmed to consistently lead to reproduction in multiple Fleet instances.
• Describe the workflow that led to the error, but have not yet been reproduced in multiple Fleet instances.

1. TODO
2. TODO

🕯️ More info (optional)

N/A

[eashaw]

Nov 21 09:23:29 AM   at=info method=GET path="/images/permanent/icon-avatar-default-128x128-2x.png?cx=35mJTvFVSVCqMgLeuCNu2SIQhkH" host=fleetdm.com request_id=9646a4d8-4c46-6cb7-faf3-6a4ba5a25ecf fwd="<redacted>" dyno=web.1 connect=0ms service=2ms status=500 bytes=21 protocol=http1.1 tls=true tls_version=tls1.3
Nov 21 09:23:29 AM   at=info method=GET path="/images/permanent/icon-avatar-default-128x128-2x.png?cx=35mJTvFVSVCqMgLeuCNu2SIQhkH" host=fleetdm.com request_id=6ee946d5-928c-fb68-33ff-2234d2f21c03 fwd="<redacted>" dyno=web.1 connect=0ms service=2ms status=500 bytes=21 protocol=http1.1 tls=true tls_version=tls1.3

I was able to reproduce this error by sending a GET request to that asset (and any asset) on my local copy of the website with an If-Match header set.

[eashaw]

I merged a PR to update the website to respond with the correct status code when this happens.

[fleet-release]

Website error fixed,
Fleet now sails smooth, unhitched.
Cloud city, no tricks.