Custom app icons no longer getting set via GitOps

[allenhouchins]

Fleet versions 4.82.0

• Discovered:
• Reproduced:

Web browser and operating system: Any

---

💥  Actual behavior

I started noticing in dogfood that my custom app icons were no longer getting set via GitOps. When I try to edit the icon in the UI, the modal just stays at a spinning logo.

🛠️ To fix

TODO

🧑‍💻  Steps to reproduce

These steps:

• Have been confirmed to consistently lead to reproduction in multiple Fleet instances.
• Describe the workflow that led to the error, but have not yet been reproduced in multiple Fleet instances.

1. Observe in dogfood by going to the Workstations fleet > Software > Available for install > Notice default app icon for Zoom, Fleet Desktop, and Fleet Keynote theme > Attempt to edit in the UI
2. Verify these icons are being set by GitOps correctly. Ex: https://github.com/fleetdm/fleet/blob/main/it-and-security/lib/macos/software/fleet-keynote-theme.yml

🕯️ More info (optional)

Nothing has changed in these files for awhile. Seems to have been introduced around 4.82.0.

[github-actions]

This issue has been automatically tagged as unreleased. If this is is incorrect, you may replace the label with ~released-bug. If this is correct, or might be correct, move this bug onto the appropriate product board to get a fix underway.

[noahtalerman]

Hey @georgekarrv giving this bug a P1 because a supported workflow is broken. I moved it over to "Ready to estimate"

I think this bug is patch release worthy.

cc @cdcme @marko-lisica