Merged
Conversation
lucasmrod
commented
Mar 14, 2023
|
|
||
| if cfg.NudgeConfig == nil { | ||
| log.Info().Msg("empty nudge config, removing nudge as target") | ||
| log.Debug().Msg("empty nudge config, removing nudge as target") |
Member
Author
There was a problem hiding this comment.
@roperzh Let me know if this is a-ok, it's a bit noisy as INFO. If this is needed I can revert.
lucasmrod
changed the title
enable_jit_role_sync config
roperzh
approved these changes
Mar 14, 2023
lucasmrod
added a commit
that referenced
this pull request
Mar 15, 2023
Forgot to run this in #10478
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#8411
We decided to only update roles for existing accounts if enabled by a new setting (disabled by default)
sso_settings.enable_jit_role_sync.[ ] Changes file added for user-visible changes inchanges/ororbit/changes/.See Changes files for more information.
[ ] Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)[ ] Documented any permissions changes[ ] Input data is properly validated,SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)[ ] Added support on fleet's osquery simulatorcmd/osquery-perffor new osquery data ingestion features.For Orbit and Fleet Desktop changes:[ ] Manual QA must be performed in the three main OSs, macOS, Windows and Linux.[ ] Auto-update manual QA, from released version of component to new version (see tools/tuf/test).