Skip to content

Typo fix: Month#11633

Closed
jinnyyi425 wants to merge 2 commits into
fleetdm:mainfrom
jinnyyi425:patch-1
Closed

Typo fix: Month#11633
jinnyyi425 wants to merge 2 commits into
fleetdm:mainfrom
jinnyyi425:patch-1

Conversation

@jinnyyi425
Copy link
Copy Markdown

Typo fix: Month

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)
  • Documented any permissions changes
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • Manual QA for all new/changed functionality
    • For Orbit and Fleet Desktop changes:
      • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
      • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

Typo fix: Month
@jinnyyi425 jinnyyi425 requested a review from mikermcneil as a code owner May 10, 2023 21:51
@fleet-release fleet-release added ~handbook Involves writing in the Fleet handbook (fleetdm.com/handbook) #g-ea labels May 10, 2023

#### External meeting scheduling
When scheduling external meetings, provide external participants with a
[Calendly](https://calendly.com) link to schedule with the relevant internal participants. If you
Copy link
Copy Markdown
Member

@mikermcneil mikermcneil May 10, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

whoops this line got deleted accidentally. Can you revert this part of the change?

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jinnyyi425 Would you please revert this change so we can merge your PR? Just let me know if I can help with that. Thanks!

mikermcneil pushed a commit that referenced this pull request Jul 3, 2023
Added proposed changes from
[PR#11633](#11633)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

~handbook Involves writing in the Fleet handbook (fleetdm.com/handbook)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants