Skip to content

fix bug in deprovisioner#12854

Merged
zwinnerman-fleetdm merged 1 commit into
mainfrom
deprovisioner_bugfis
Jul 19, 2023
Merged

fix bug in deprovisioner#12854
zwinnerman-fleetdm merged 1 commit into
mainfrom
deprovisioner_bugfis

Conversation

@zwinnerman-fleetdm
Copy link
Copy Markdown
Contributor

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any API changes (docs/Using-Fleet/REST-API.md or docs/Contributing/API-for-contributors.md)
  • Documented any permissions changes
  • Input data is properly validated, SELECT * is avoided, SQL injection is prevented (using placeholders for values in statements)
  • Added support on fleet's osquery simulator cmd/osquery-perf for new osquery data ingestion features.
  • Added/updated tests
  • Manual QA for all new/changed functionality
    • For Orbit and Fleet Desktop changes:
      • Manual QA must be performed in the three main OSs, macOS, Windows and Linux.
      • Auto-update manual QA, from released version of component to new version (see tools/tuf/test).

@zwinnerman-fleetdm zwinnerman-fleetdm requested a review from a team as a code owner July 19, 2023 23:30
@fleet-release fleet-release requested a review from lukeheath July 19, 2023 23:30
@zwinnerman-fleetdm zwinnerman-fleetdm temporarily deployed to Docker Hub July 19, 2023 23:30 — with GitHub Actions Inactive
@codecov
Copy link
Copy Markdown

codecov Bot commented Jul 19, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01 ⚠️

Comparison is base (0b7ef3d) 58.53% compared to head (20ee0ce) 58.53%.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #12854      +/-   ##
==========================================
- Coverage   58.53%   58.53%   -0.01%     
==========================================
  Files         860      860              
  Lines       69298    69334      +36     
  Branches     1783     1783              
==========================================
+ Hits        40563    40583      +20     
- Misses      25472    25486      +14     
- Partials     3263     3265       +2     
Flag Coverage Δ
backend 58.86% <ø> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 5 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

@zwinnerman-fleetdm zwinnerman-fleetdm merged commit d6f51f8 into main Jul 19, 2023
@zwinnerman-fleetdm zwinnerman-fleetdm deleted the deprovisioner_bugfis branch July 19, 2023 23:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants