Add additional meetings to the engineering handbook#13196
Merged
Conversation
lukeheath
requested review from
georgekarrv,
sabrinabuckets,
sharon-fdm and
xpkoala
fleet-release
added
the
~handbook
fleet-release
approved these changes
Aug 8, 2023
lukeheath
changed the title
fleet-release
previously approved these changes
Aug 8, 2023
sabrinabuckets
previously requested changes
Aug 8, 2023
Contributor
sabrinabuckets
left a comment
sabrinabuckets
left a comment
There was a problem hiding this comment.
@lukeheath lines 112-125 look to have been accidentally duplicated, as they are part of the Eng together meeting.
Otherwise looks good.
georgekarrv
requested changes
Aug 8, 2023
Comment on lines
+112
to
+125
| #### Participants | ||
|
|
||
| Everyone at the company is welcome to attend. All engineers are asked to attend. The subject matter is focused on engineering. | ||
|
|
||
| #### Agenda | ||
|
|
||
| - Announcements | ||
| - Engineering KPIs review | ||
| - “Tech talks” | ||
| - At least one engineer from each product group demos or discusses a technical aspect of their recent work. | ||
| - Everyone is welcome to present on a technical topic. Add your name and tech talk subject in the agenda doc included in the Eng Together calendar event. | ||
| - Social | ||
| - Structured and/or unstructured social activities | ||
|
|
Member
There was a problem hiding this comment.
@sabrinabuckets is correct, this section should be removed as it's a duplication.
Member
Author
|
@sabrinabuckets @georgekarrv Thanks for catching that! Fixed. |
georgekarrv
approved these changes
Aug 11, 2023
fleet-release
approved these changes
Aug 15, 2023
mikermcneil
added a commit
that referenced
this pull request
Aug 15, 2023
Automation: Try removing trailing slash on `handbook/` in this config to verify that editing #13196 as me does put the `#g-ceo` label properly back on this PR.
mikermcneil
added a commit
that referenced
this pull request
Aug 15, 2023
Automation: Try removing trailing slash on `handbook/` in this config to verify that editing #13196 as me does put the `#g-ceo` label properly back on this PR. If that doesn't work, then we need to keep digging into what's wrong.
Member
|
@sabrinabuckets @lukeheath @georgekarrv @sharon-fdm @xpkoala Sorry guys for not getting back to this faster. We ran into a problem with the We're going to use this PR as a guinea pig for some experimentation this evening but it'll be merged shortly. |
fleet-release
approved these changes
Aug 15, 2023
fleet-release
approved these changes
Aug 15, 2023
mikermcneil
approved these changes
Aug 15, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
. . .