Allow to configure fleetd for script execution#13564
Conversation
Related to #13310 and #13304 this adds two ways to enable script execution in `fleetd` (the orbit component) - By building a package with `--enable-scripts` - By providing a setting via a configuration profile (macOS only) > [!NOTE] > Documentation will be added in a separate PR to decouple reviews.
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #13564 +/- ##
==========================================
- Coverage 58.85% 58.80% -0.06%
==========================================
Files 891 892 +1
Lines 72980 73109 +129
Branches 2079 2079
==========================================
+ Hits 42955 42990 +35
- Misses 26580 26669 +89
- Partials 3445 3450 +5
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
mna
left a comment
mna
left a comment
There was a problem hiding this comment.
Nice! Will integrate this in my PR as soon as it merges.
| // not have a configuration profile, or to get into this situation in | ||
| // operating systems that don't have profile support. | ||
| case errors.Is(err, profiles.ErrNotImplemented), errors.Is(err, profiles.ErrNotFound): | ||
| log.Debug().Msgf("reading configuration profile: %v", err) |
There was a problem hiding this comment.
Not sure I understand why adding the new flag makes that unnecessary?
There was a problem hiding this comment.
Ah I think I see, the ErrNotFound is not returned anymore when secret+ url are empty, but that doesn't matter because anyway we check if any of those are empty don't use them if that's the case.
3 participants
Related to #13310 and #13304 this adds two ways to enable script execution in
fleetd(the orbit component)--enable-scriptsDue to how the profile assignment works, this change automatically updates the
com.fleetdm.fleetd.configfor hosts that already have the profile installed.Note
Documentation is in #13577 to decouple reviews.
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.See Changes files for more information.