add docs for scripts results API#13720
Merged
Merged
Conversation
mna
reviewed
Sep 5, 2023
mna
reviewed
Sep 5, 2023
Contributor
mna
left a comment
mna
left a comment
There was a problem hiding this comment.
LGTM except for the pending renaming of hostname.
mna
previously approved these changes
Sep 5, 2023
rachaelshaw
requested changes
Sep 5, 2023
Co-authored-by: Rachael Shaw <r@rachael.wtf>
Contributor
Author
|
@rachaelshaw thanks so much! I incorporated your feedback, do you mind taking another look? |
roperzh
pushed a commit
that referenced
this pull request
Sep 5, 2023
Contributor
Author
|
as doc changes are allowed during the freeze, I'm merging. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
sibling PR #13701