Skip to content

Launch transparency page for fleetdm.com#1391

Merged
gillespi314 merged 3 commits intomainfrom
fleetdm-transparency
Jul 15, 2021
Merged

Launch transparency page for fleetdm.com#1391
gillespi314 merged 3 commits intomainfrom
fleetdm-transparency

Conversation

@gillespi314
Copy link
Copy Markdown
Contributor

Closes #465

@gillespi314
Copy link
Copy Markdown
Contributor Author

@mike-j-thomas I used your accordion from the pricing FAQ 😀 🙌

Copy link
Copy Markdown
Member

@mikermcneil mikermcneil left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The code is lovely.

@mikermcneil
Copy link
Copy Markdown
Member

You know... I wonder how users will find this page prior to the release of Fleet Desktop? #1391

I think this needn’t block the merge 🧱🧜
Maybe we link to it in lieu of one of the CTAs on the homepage, docs, or elsewhere?

@mike-j-thomas
Copy link
Copy Markdown
Member

I've been pondering that too. For now I figured it would be linked to via the docs, blog, tweet, comments where it can be added to the discussion.

I also thought that it may accelerate the "product" page (draft content here). That seems like a logical place to me to link it from directly on the site.

@mikermcneil
Copy link
Copy Markdown
Member

sounds good, let’s do it in a tweet, in a short narrative blog post, and in one place in the docs.

Tangent: Love the product page concept so far. Schedule it for further development after we ship the next gen of “Get started”

@gillespi314 After it’s been given the old Mikey Tom, feel free to merge your own website PRs without waiting for my review.

(Caveat: please do lmk about proposed changes to config/, hooks/, and the content build script so I can keep a handle on where it’s going architecturally)

@gillespi314
Copy link
Copy Markdown
Contributor Author

gillespi314 commented Jul 14, 2021

(Caveat: please do lmk about proposed changes to config/, hooks/, and the content build script so I can keep a handle on where it’s going architecturally)

@mikermcneil are you referring to #1380 or some other proposed changes?

EDIT: Ahh, I understand your comment now... will definitely check in with you if I'm making any proposed changes in those areas

Copy link
Copy Markdown
Member

@mike-j-thomas mike-j-thomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looking good. "File contents" accordion needs fixing up (it's opening the accordion above it). I added the change on the review.

"Not" is rendering incorrectly for me.
Screen Shot 2021-07-15 at 8 34 04

And text here needs to be center aligned for <= medium.

image

Good to merge after these.

Thanks!

Comment thread website/views/pages/transparency.ejs Outdated
Comment thread website/views/pages/transparency.ejs Outdated
@gillespi314 gillespi314 merged commit 87ab319 into main Jul 15, 2021
@gillespi314 gillespi314 deleted the fleetdm-transparency branch July 15, 2021 14:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Scope transparency

3 participants