Add null logging to avoid issues on load tests#14754
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #14754 +/- ##
==========================================
- Coverage 58.85% 58.83% -0.02%
==========================================
Files 925 926 +1
Lines 77287 77295 +8
Branches 2222 2222
==========================================
- Hits 45487 45477 -10
- Misses 28190 28205 +15
- Partials 3610 3613 +3
Flags with carried forward coverage won't be shown. Click here to find out more.
☔ View full report in Codecov by Sentry. |
@lucasmrod can't we just use |
That is possible yes, but may come with a cost ($ for log storage). |
Let us know if you would like to tackle this on the infrastructure side. Such change (or this one) will be necessary to perform new load tests on query reports. |
|
@noahtalerman (forgot to cc) |
|
If you want to really not send the data anywhere, picking a filesystem destination and choosing /dev/null as the file path might be the easiest solution. |
Ah good idea. I'll close this and open a separate PR for infrastructure changes. |
|
Closed in favor of #14848 |
…14848) This is to avoid firehose (rate limit) errors when load testing query reports with thousands of hosts. (And may reduce cost by storing logs nowhere.) Thanks @rfairburn: #14754 (comment)
We really needed something like this during load tests for #7766 (to not get those Firehose errors while working at a high load using scheduled queries). This will be useful for any subsequent load test.
@rachaelshaw/@noahtalerman Let me know if:
null.Let me know if you want me to create an issue for this.
(*) AFAICS this is only useful for load-testing/internal-use.