Skip to content

chore: update go.mod to pull latest scep changes#16044

Merged
jahzielv merged 2 commits into
mainfrom
15635-scep-status
Jan 11, 2024
Merged

chore: update go.mod to pull latest scep changes#16044
jahzielv merged 2 commits into
mainfrom
15635-scep-status

Conversation

@jahzielv
Copy link
Copy Markdown
Contributor

@jahzielv jahzielv commented Jan 11, 2024

📜 Related issue: #15635

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

Tests were added in the scep repo: mikermcneil/fleet-scep#1

@jahzielv jahzielv requested a review from a team as a code owner January 11, 2024 14:54
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 11, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (3b2e97d) 66.06% compared to head (acf67ec) 65.99%.
Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #16044      +/-   ##
==========================================
- Coverage   66.06%   65.99%   -0.07%     
==========================================
  Files        1083     1083              
  Lines       94824    94824              
  Branches     2413     2413              
==========================================
- Hits        62648    62582      -66     
- Misses      27546    27601      +55     
- Partials     4630     4641      +11     
Flag Coverage Δ
backend 67.12% <ø> (-0.08%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Copy Markdown
Contributor

@roperzh roperzh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jahzielv jahzielv merged commit e3ae0b3 into main Jan 11, 2024
@jahzielv jahzielv deleted the 15635-scep-status branch January 11, 2024 15:13
georgekarrv pushed a commit that referenced this pull request Jan 12, 2024
> 📜 Related issue: #15635

# Checklist for submitter

If some of the following don't apply, delete the relevant line.

<!-- Note that API documentation changes are now addressed by the
product design team. -->

- [x] Changes file added for user-visible changes in `changes/` or
`orbit/changes/`.
See [Changes
files](https://fleetdm.com/docs/contributing/committing-changes#changes-files)
for more information.
- [x] Added/updated tests
- [x] Manual QA for all new/changed functionality

Tests were added in the scep repo:
mikermcneil/fleet-scep#1
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants