Fixed macOS MSI package -- using local wine and wix#16307
Conversation
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #16307 +/- ##
==========================================
+ Coverage 65.46% 65.53% +0.07%
==========================================
Files 1124 1127 +3
Lines 97575 98765 +1190
Branches 2413 2413
==========================================
+ Hits 63875 64729 +854
- Misses 28918 29167 +249
- Partials 4782 4869 +87
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@noahtalerman FYI. The new flow for The change is that this flow will no longer use docker, and will use a local build flow. |
mostlikelee
left a comment
There was a problem hiding this comment.
Some initial questions, primarily for Product:
- is it reasonable to ask customers to install homebrew, wget, and wine?
lucasmrod
left a comment
There was a problem hiding this comment.
Looks good, left a couple of comments.
| for _, archiveReader := range zipReader.File { | ||
| err = extractZipFile(archiveReader, destPath) | ||
| if err != nil { | ||
| return err | ||
| } | ||
| } |
Check failure
Code scanning / CodeQL
Arbitrary file access during archive extraction ("Zip Slip")
@getvictor and @mostlikelee what are the required tools today v. what they will be with this change? @getvictor is this PR also a fix for "fleetctl on Apple Silicon" (#9047) ? If so, what are the required tools v. what they will be after this change? Trying to get a feel for whether this is a step in the right direction: fewer dependencies = better UX |
|
We may need similar docs here: fleet/docs/Using Fleet/enroll-hosts.md Lines 297 to 313 in 7d00d5a |
|
@noahtalerman The current requirement is to have docker installed. The new requirement is to have wine installed. We need this fix, since the current flow fails half the time, and always prints error messages such as: The fix for #9047 has already been merged into main. |
Co-authored-by: Noah Talerman <47070608+noahtalerman@users.noreply.github.com>
|
@lucasmrod Please re-review. I met with Noah to review this PR and made some changes. |
lucasmrod
left a comment
There was a problem hiding this comment.
Looks good. Left a small comment around checking the response status.
Also, should we add docs here?
https://github.com/fleetdm/fleet/blob/main/docs/Using%20Fleet/enroll-hosts.md?plain=1#L297-L313
Docs added in this PR: #16459 |
New flow for
fleetctl --package --type=msion macOS using arm64 processor (M1, M2, etc.)Building Windows .msi packages for fleetd on Apple Silicon #15463
PR for docs: #16459
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.See Changes files for more information.