gitops role authorization changes for fleetctl gitops#16710
Merged
Conversation
4 tasks
sharon-fdm
reviewed
Feb 9, 2024
Collaborator
There was a problem hiding this comment.
I think we are missing tests for:
Query read team
Query write global and team
Policy read team
Policy write global and team
Collaborator
There was a problem hiding this comment.
NVM. Saw tests in other files.
lucasmrod
previously approved these changes
Feb 9, 2024
sharon-fdm
previously approved these changes
Feb 9, 2024
sharon-fdm
approved these changes
Feb 9, 2024
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #16710 +/- ##
==========================================
+ Coverage 65.67% 65.78% +0.11%
==========================================
Files 1137 1139 +2
Lines 99527 100121 +594
Branches 2459 2459
==========================================
+ Hits 65365 65867 +502
- Misses 29278 29340 +62
- Partials 4884 4914 +30
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
lucasmrod
approved these changes
Feb 9, 2024
rachaelshaw
approved these changes
Feb 12, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
To support
fleetctl gitops, gitops role can now read policies/queries and write scripts.Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/ororbit/changes/.See Changes files for more information.