Skip to content

For fleetctl gitops, when MDM configs are not explicitly defined in gitops yml file, they are now set to default values.#17223

Merged
getvictor merged 8 commits intomainfrom
victor/17209-fleetctl-gitops-mdm-configs
Mar 7, 2024
Merged

For fleetctl gitops, when MDM configs are not explicitly defined in gitops yml file, they are now set to default values.#17223
getvictor merged 8 commits intomainfrom
victor/17209-fleetctl-gitops-mdm-configs

Conversation

@getvictor
Copy link
Copy Markdown
Member

@getvictor getvictor commented Feb 27, 2024

For fleetctl gitops, when MDM configs are not explicitly defined in gitops yml file, they are now set to default values.
#17209

Gitops role can now read org config/settings. This is used to determine whether license is Premium.
Doc changes for permission access: #17238

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/ or orbit/changes/.
    See Changes files for more information.
  • Documented any permissions changes (docs/Using Fleet/manage-access.md)
  • Added/updated tests
  • Manual QA for all new/changed functionality

@getvictor
Copy link
Copy Markdown
Member Author

@noahtalerman I'm adding the ability for gitops user to read fleet config, so that it can know if Fleet Premium is used. The config access is not documented, so it should not require doc changes.

@noahtalerman
Copy link
Copy Markdown
Member

I'm adding the ability for gitops user to read fleet config, so that it can know if Fleet Premium is used.

@getvictor makes sense.

The config access is not documented, so it should not require doc changes.

By config do you mean info included in the GET /config endpoint?

If so, I think we document this in several rows in the permissions table here:

Screenshot 2024-02-28 at 10 53 18 AM

There might be more rows I'm missing.

@getvictor
Copy link
Copy Markdown
Member Author

I'm adding the ability for gitops user to read fleet config, so that it can know if Fleet Premium is used.

@getvictor makes sense.

The config access is not documented, so it should not require doc changes.

By config do you mean info included in the GET /config endpoint?

If so, I think we document this in several rows in the permissions table here:

Screenshot 2024-02-28 at 10 53 18 AM

There might be more rows I'm missing.

You're right, I saw looking for config and not settings. I'll update docs in a separate PR.

@codecov
Copy link
Copy Markdown

codecov Bot commented Feb 28, 2024

Codecov Report

Attention: Patch coverage is 92.94118% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 65.51%. Comparing base (977c376) to head (9713d69).
Report is 2 commits behind head on main.

Files Patch % Lines
cmd/fleetctl/gitops.go 25.00% 4 Missing and 2 partials ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main   #17223      +/-   ##
==========================================
+ Coverage   65.50%   65.51%   +0.01%     
==========================================
  Files        1192     1192              
  Lines      107474   107551      +77     
  Branches     2569     2569              
==========================================
+ Hits        70399    70463      +64     
- Misses      31702    31710       +8     
- Partials     5373     5378       +5     
Flag Coverage Δ
backend 66.51% <92.94%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@getvictor getvictor force-pushed the victor/17209-fleetctl-gitops-mdm-configs branch from ee5a081 to 73eb7e4 Compare March 5, 2024 16:34
@getvictor getvictor marked this pull request as ready for review March 5, 2024 21:05
@getvictor getvictor requested a review from a team as a code owner March 5, 2024 21:05
Copy link
Copy Markdown
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Really cool integration tests!

@getvictor getvictor merged commit a173be8 into main Mar 7, 2024
@getvictor getvictor deleted the victor/17209-fleetctl-gitops-mdm-configs branch March 7, 2024 19:20
getvictor added a commit that referenced this pull request Mar 7, 2024
Allowing GitOps role to read org configs.

Docs for #17223
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants