Skip to content

Added FLEET_CALENDAR_PERIODICITY for internal demo use.#19559

Merged
getvictor merged 3 commits into
mainfrom
victor/19491-maintenance-window-frequency
Jun 10, 2024
Merged

Added FLEET_CALENDAR_PERIODICITY for internal demo use.#19559
getvictor merged 3 commits into
mainfrom
victor/19491-maintenance-window-frequency

Conversation

@getvictor
Copy link
Copy Markdown
Member

#19491

Video demo: https://www.loom.com/share/c8fca008a9674cc685a5c209d9689271?sid=1f67e6c5-5e0b-4f10-9837-dc5d4c27f858

Changes file not added since this is an undocumented feature for internal use.

New tests not created since this feature is for internal use, and will likely be removed in the near future.

Checklist for submitter

If some of the following don't apply, delete the relevant line.

  • Changes file added for user-visible changes in changes/, orbit/changes/ or ee/fleetd-chrome/changes.
    See Changes files for more information.
  • Added/updated tests
  • Manual QA for all new/changed functionality

@getvictor getvictor marked this pull request as ready for review June 6, 2024 18:33
@getvictor getvictor requested a review from a team as a code owner June 6, 2024 18:34
Comment thread server/config/config.go
// Calendar integration
man.addConfigDuration(
"calendar.periodicity", 0,
"How much time to wait between processing calendar integration.",
Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit, period at end maybe not necessary.

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also add that 0 means 5m?

Copy link
Copy Markdown
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@getvictor getvictor merged commit 6a20231 into main Jun 10, 2024
@getvictor getvictor deleted the victor/19491-maintenance-window-frequency branch June 10, 2024 19:27
lukeheath added a commit that referenced this pull request Jun 10, 2024
From this PR: #19559

---------

Co-authored-by: Robert Fairburn <8029478+rfairburn@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants