Fix Deleted Host Software Installs Details#20820
Merged
dantecatalfamo merged 22 commits intomainfrom Aug 1, 2024
Merged
Conversation
dantecatalfamo
changed the title
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
requested review from
a team,
getvictor,
gillespi314,
lucasmrod and
roperzh
as code owners
dantecatalfamo
changed the title
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
roperzh
reviewed
Jul 29, 2024
Contributor
roperzh
left a comment
roperzh
left a comment
There was a problem hiding this comment.
nice work! I think there are minor changes in other places that need to account for this change.
We had a discussion about this with Martin at #19457 (review)
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
Member
Author
|
@roperzh I made a change to only count software where |
roperzh
previously approved these changes
Aug 1, 2024
Contributor
roperzh
left a comment
roperzh
left a comment
There was a problem hiding this comment.
sorry for the delay reviewing, I know this causes pain because you have to fix conflicts and migrations now.
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
This reverts commit a0f54a9.
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
roperzh
previously approved these changes
Aug 1, 2024
dantecatalfamo
had a problem deploying
to
Docker Hub
GitHub Actions
Error
dantecatalfamo
temporarily deployed
to
Docker Hub
GitHub Actions
Inactive
roperzh
approved these changes
Aug 1, 2024
roperzh
pushed a commit
that referenced
this pull request
Aug 2, 2024
#20271 This fix requires an accompanying front end fix to pass the `display_name` from the activity feed to the modal when displaying the install results.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
#20271
This fix requires an accompanying front end fix to pass the
display_namefrom the activity feed to the modal when displaying the install results.changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)COLLATE utf8mb4_unicode_ci).