Merged
Conversation
…om base64 to fix the issue of incorrect profile format
roperzh
approved these changes
Aug 2, 2024
Contributor
roperzh
left a comment
roperzh
left a comment
There was a problem hiding this comment.
LGTM! thank you!!
unfortunately tests are broken in main, but this seems 100% all the changes needed.
roperzh
pushed a commit
that referenced
this pull request
Aug 7, 2024
roperzh
added a commit
that referenced
this pull request
Aug 7, 2024
Closed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
FLEET_SILENT_MIGRATION_ENROLLMENT_PROFILEshould be expected to be a base64 encoded string of an enrollment file. Encoding is necessary as encrypted profiles have binary data which doesn't work well as env var values.