Skip to content

chore: fix change file location#21369

Merged
lucasmrod merged 1 commit into
fleetdm:mainfrom
ilpianista:bugfix/change-file
Aug 29, 2024
Merged

chore: fix change file location#21369
lucasmrod merged 1 commit into
fleetdm:mainfrom
ilpianista:bugfix/change-file

Conversation

@ilpianista
Copy link
Copy Markdown
Contributor

This change file is in the wrong place :-)

@ilpianista ilpianista changed the title Fix change file location chore: fix change file location Aug 16, 2024
@ilpianista
Copy link
Copy Markdown
Contributor Author

@jacobshandling friendly ping since that file has been created by you

Copy link
Copy Markdown
Member

@lucasmrod lucasmrod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for catching this @ilpianista!

We can probably delete this file because it's 7 months old and the change was already released.

@lucasmrod lucasmrod self-assigned this Aug 29, 2024
@lucasmrod
Copy link
Copy Markdown
Member

I'll be merging this as-is and removing it from main.

@lucasmrod lucasmrod merged commit d8e5c11 into fleetdm:main Aug 29, 2024
@lucasmrod
Copy link
Copy Markdown
Member

Here's the PR to remove it: #21685.

lucasmrod added a commit that referenced this pull request Aug 29, 2024
This lingering changes was first detected by
#21369 (the user moved it to the
correct place and this PR is removing it).
I traced the PR that added the change to the wrong location to an issue
with the milestone 4.44.1.
@ilpianista ilpianista deleted the bugfix/change-file branch August 30, 2024 08:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants