Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #21942 +/- ##
==========================================
+ Coverage 64.94% 64.95% +0.01%
==========================================
Files 1492 1492
Lines 116312 116554 +242
Branches 3414 3473 +59
==========================================
+ Hits 75537 75710 +173
- Misses 33762 33794 +32
- Partials 7013 7050 +37
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
mna
left a comment
mna
left a comment
There was a problem hiding this comment.
LGTM, I'm not familiar with the details of the protocol but it all makes sense!
| // believe this could be done with a little bit of reverse | ||
| // engineering/cleverness but for now, we're signing the request with | ||
| // our mock certs and setting this env var to skip the verification. | ||
| os.Setenv("FLEET_DEV_MDM_APPLE_DISABLE_DEVICE_INFO_CERT_VERIFY", "1") |
There was a problem hiding this comment.
Just to make sure, this will work for integration tests as the mocked devices and the server are in the same process, but this won't work for load tests /osquery_perf, right?
There was a problem hiding this comment.
I think you're right. For osquery_perf you'll need to add it in the terraform file that starts the fleet server. I just created a separate PR with the documentation here #21950 to alleviate the amount of codeowners
thiw new env var is being added in #21942
3 participants
for #21019
Checklist for submitter
If some of the following don't apply, delete the relevant line.
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)