[fleetctl] fix deb package build#23796
[fleetctl] fix deb package build#23796lucasmrod merged 1 commit intofleetdm:mainfrom ilpianista:bugfix/create-build-dir
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #23796 +/- ##
==========================================
- Coverage 63.12% 63.12% -0.01%
==========================================
Files 1557 1558 +1
Lines 147693 147866 +173
Branches 3687 3687
==========================================
+ Hits 93236 93336 +100
- Misses 47073 47138 +65
- Partials 7384 7392 +8
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. |
|
@ilpianista Thank you for the contribution! We will review soon. |
There was a problem hiding this comment.
Thanks @ilpianista! I was able to reproduce. I'll merge and make some changes on top of it (use opt.NativeTooling to distinguish between fleetctl executable run mode vs. docker mode)
I've created #23893 to track this bug.
|
PR: #23894 with the changes on top of these changes. Thanks again @ilpianista! (will be released in v4.61.0) |
#23893 Changes on top of the PR from the @ilpianista: #23796
I'm trying to setup a GitLab CI job to build the deb packages, but it fails with:
It happens because I can't mount the
buildvolume as I would do on my local pc. To reproduce:pkgandmsiworks fine. I can workaround it by creating thebuilddir first, but I think that's also fleetctl job to create it.Checklist for submitter
changes/,orbit/changes/oree/fleetd-chrome/changes.See Changes files for more information.
SELECT *is avoided, SQL injection is prevented (using placeholders for values in statements)cmd/osquery-perffor new osquery data ingestion features.COLLATE utf8mb4_unicode_ci).runtime.GOOS).