Skip to content

YAML files reference docs: windows_migration_enabled#24891

Merged
noahtalerman merged 1 commit into
mainfrom
noahtalerman-patch-18
Dec 19, 2024
Merged

YAML files reference docs: windows_migration_enabled#24891
noahtalerman merged 1 commit into
mainfrom
noahtalerman-patch-18

Conversation

@noahtalerman
Copy link
Copy Markdown
Member

- Add missing reference docs for the following user story:
  - #22075
@noahtalerman
Copy link
Copy Markdown
Member Author

FYI @allenhouchins the new setting, windows_migration_enabled, does live under controls top-level key. We specify in the docs that it's default.yml only. Same for windows_enabled_and_configured and macos_migration (see below)

Screenshot 2024-12-18 at 5 53 49 PM

Screenshot 2024-12-18 at 5 53 20 PM

@lucasmrod do all 3 of these settings also work when you put them under /no-team.yml? Today, in dogfood today we have windows_enabled_and_configured set in /no-team.yml and not in default.yml.

@lucasmrod
Copy link
Copy Markdown
Member

Do you mean these ones?

macos_migration:
enable: true
mode: voluntary
webhook_url: $DOGFOOD_MACOS_MIGRATION_WEBHOOK_URL

Basically whatever is under controls: can be put in no-team.yml (provided you are defining controls: in only one of the two no-team.yml or default.yml)

@lucasmrod
Copy link
Copy Markdown
Member

But if windows_migration_enabled is a global setting maybe it should not be under controls?

@noahtalerman noahtalerman merged commit 5f9fcfc into main Dec 19, 2024
@noahtalerman noahtalerman deleted the noahtalerman-patch-18 branch December 19, 2024 19:37
noahtalerman added a commit that referenced this pull request Dec 19, 2024
- The new config is flat. We just updated the docs here: #24891
@noahtalerman
Copy link
Copy Markdown
Member Author

noahtalerman commented Dec 19, 2024

(provided you are defining controls: in only one of the two no-team.yml or default.yml)

@lucasmrod do we return an easy to understand error message if you have controls in no-team.yml and default.yml?

if windows_migration_enabled is a global setting maybe it should not be under controls?

Agreed. Probably should be under org_settings in default.yml. Customers who want to use controls (ex. configuration profiles) on "No team" team will have a weird experience. I tracked this as a feature request here so we don't lose it: #24938

allenhouchins pushed a commit that referenced this pull request Dec 19, 2024
- The new config is flat. We just updated the docs here:
#24891
@lucasmrod
Copy link
Copy Markdown
Member

do we return an easy to understand error message if you have controls in no-team.yml and default.yml?

We fail fleetctl gitops with the following error: 'controls' cannot be set on both global config and on no-team.yml.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants