Add note about script execution timeout config#25189
Merged
sgress454 merged 1 commit intodocs-v4.63.0from Jan 7, 2025
Merged
Conversation
lucasmrod
approved these changes
Jan 7, 2025
sgress454
added a commit
that referenced
this pull request
Jan 7, 2025
relates to #24247 There's nothing actually wrong in the current docs. We document that to set `script_execution_timeout` in a YAML file you do: ```yaml agent_options: script_execution_timeout: 600 ``` which is correct. It's just that in the UI we hide the top-level `agent_options` key entirely. This makes sense from a UX standpoint but it's easy to see how someone could get confused. The _best_ option would be to have `script_execution_timeout` always returned from the config endpoint so that it appeared in the right place in the UI and the user would just have to edit it, but I'd wait for more reports on this before committing that level of effort.
rachaelshaw
pushed a commit
that referenced
this pull request
Jan 7, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
relates to #24247
There's nothing actually wrong in the current docs. We document that to set
script_execution_timeoutin a YAML file you do:which is correct. It's just that in the UI we hide the top-level
agent_optionskey entirely. This makes sense from a UX standpoint but it's easy to see how someone could get confused. The best option would be to havescript_execution_timeoutalways returned from the config endpoint so that it appeared in the right place in the UI and the user would just have to edit it, but I'd wait for more reports on this before committing that level of effort.